jet / FsKafka

Minimal F# wrappers for Confluent.Kafka+librdkafka.redist 1.x
https://github.com/jet/dotnet-templates
Apache License 2.0
88 stars 17 forks source link

Why consumer is key=string, value=string? #26

Closed vasily-kirichenko closed 5 years ago

bartelink commented 5 years ago

Are you referring to the v1 or v0 branches?

Assuming v1; that is as it is because it's extracted from a running system which centered on Confluent.Kafka v 0.11.4 and a serializer (Json.net IIRC) that works off a string rendering (and typically keys map to stream names in upstream event-based storage systems).

Happy to take PRs to generalize (with tests please if it's an interesting change to any degree but I'm assuming you're just talking about removing some hard-coding).

bartelink commented 5 years ago

Closing for age