Target Confluent.Kafka 1.2.0

jet / FsKafka

Minimal F# wrappers for Confluent.Kafka+librdkafka.redist 1.x

https://github.com/jet/dotnet-templates

Apache License 2.0

88 stars 17 forks source link

Target Confluent.Kafka 1.2.0 #44

Closed bartelink closed 5 years ago

bartelink commented 5 years ago

[x] handles one minor change in underlying CK API (change from int -> float) - surface API does not change
[x] Adds a config optional arg on config ctors to align with CK API's new IDictionayr<string,string> overload

bartelink commented 5 years ago

@szer is 8ae2f95 a good idea? Its obviously a potentially breaking change, but should be easy enough to adapt to?

I know it's an extra alloc and the impl is ugly. But I can't think of a cleaner way to align with the way that the 1.2 interface has a new IDictionary<string,string> overload

Wait - I'll support both and call the new one config so it matches exactly, doh!

Szer commented 5 years ago

I think it's an easy thing to adapt to for sure. Seq of value pairs to dictionary seems like a natural conversion.

Extra allocation is fine because you couldn't preallocate shared instance of empty mutable(!) dictionary.

bartelink commented 5 years ago

Sorry, I edited my comment :shame: - I found a better way which is to give it a new name which matches the equivalent CK arg.