search

jet / dotnet-templates

Example app and service templates `dotnet new -i Equinox.Templates; dotnet new eqx*/pro*` https://github.com/jet/equinox https://github.com/jet/FsCodec
https://github.com/jet/propulsion
Apache License 2.0
64 stars 16 forks source link

Upgrade to dotnet 2.2 #9

Closed aarondandy closed 4 years ago

aarondandy commented 5 years ago

I'm not really sure if this is even much of a problem but I noticed that the generated web app when using eqxwebcs will reference the newer 2.2 version of Microsoft.AspNetCore.App but the project targets netcoreapp2.1. I'm unsure if this is a bug or feature, thoughts?

See: https://github.com/jet/dotnet-templates/blob/73b380b270c7794714aee0bf36e61204eaa22a0d/equinox-web-csharp/Web/Web.csproj#L4

bartelink commented 5 years ago

Very eagle eyed of you ;)

In general for the template, the aim is to have as few expectations as possible e.g.

In the Equinox repo, from which the F# version is derived, and the C# one was hand-cloned, the repo pins the SDK version to 2.1.402.

I suspect doing that in this repo is probably a good idea for predictable experience.

I'm not sure what the recommended approach is wrt all this in a dotnet template - i.e. I'm not sure how keeping web templates in step with aspnetcore is supposed to work. (Cant fish out a link for the fact that VS still needs these templates to be wrapped in a VS gallery installer thing when third party IDEs can consume them from the registered dotnet new list no problem; hopefully there will be clear guidance and/or a proper story for this before VS 2019 ships in full)

bartelink commented 5 years ago

I'm thinking to close as a wontfix, as I personally don't have space for it, and it seems relatively low priority - what say you @aarondandy ?

bartelink commented 4 years ago

We'll likely move stuff to netcoreapp3.1 as the v3 branches for Equinox and Propulsion (which do same) become master

bartelink commented 4 years ago

Resolved by #48. General intention is to have templates target LTS versions, but as these these templates are not tied closely to the framework as a whole, there's no major impetus to require anything more stringent than that as far as I can determine.