jet / dotnet-templates

Example app and service templates `dotnet new -i Equinox.Templates; dotnet new eqx*/pro*` https://github.com/jet/equinox https://github.com/jet/FsCodec
https://github.com/jet/propulsion
Apache License 2.0
64 stars 16 forks source link

Target Equinox 3.0.0, Propulsion 2.10.0 #90

Closed bartelink closed 3 years ago

bartelink commented 3 years ago

@deviousasti I'm parking this for now as there's a thorny set of inconsistencies between multiple type Stats implementations in Propulsion. While it'd be nice to have a fix in the short term, and Propulsion 2.10.1 will likely be a tiny change in terms of number. of lines needing changing, I simply can't confidently put an upper limit on how long the fight would be... (Also my hunch is that this case does not occur in the Financials prod repo)

The removal of the Kafka-specific clone of the Stats type is definitely a required decision in order to enable Prometheus metrics to be managed consistently between CFP and Kafka, i.e. reverting Propulsion.Kafka.StreamsConsumerStats removal is a really bad idea, but we're paying for me punting on fighting the compiler for another few hours when I last ran into that (so I left them as clones with very minor differences rather than arriving at a correct common abstraction). All I can say in my defense is that I'm glad I sucked it up and wrote the tests in this repo despite not being able to convince anyone of the merit verbally!