search

jetbalsa / pos-tracker-eve

Automatically exported from code.google.com/p/pos-tracker-eve
0 stars 0 forks source link

Patch for /trunk/cron_mail.php #42

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Fix required fuel in email

Original issue reported on code.google.com by scott.mu...@gmail.com on 26 Sep 2011 at 6:10

Attachments:

GoogleCodeExporter commented 9 years ago 
Updated fix to actually work. Added into 5.1.7.

Original comment by frozenic...@gmail.com on 29 Sep 2011 at 10:37

GoogleCodeExporter commented 9 years ago 
What do you mean "to actually work"?

Original comment by scott.mu...@gmail.com on 30 Sep 2011 at 2:31

GoogleCodeExporter commented 9 years ago 
There was no AllianceID being pulled in. So your settings still defaulted to 0 
which it did in the past. So all towers looked the same as they pulled always 
from the static table instead of the sov table even if the tower had sov.

Not to be mean or anything but you need to actually test your patches to see if 
they actually make the change you expect to happen. Same was with the SQL 
noticed here:

http://code.google.com/p/pos-tracker-eve/issues/detail?id=32

there is no such word contellation in all of the POS tracker. Yet this code was 
posted in the issue and on the forums as a fix. A fix that technically doesn't 
completely work.

Original comment by frozenic...@gmail.com on 30 Sep 2011 at 3:18

GoogleCodeExporter commented 9 years ago 
You're right about the 'contellation' fix. That was a typo. I did execute the 
correct SQL on my server to resolve the issue though.

As per the alliance ID, the fix looked like it worked for me. I saw values in 
the email where there were none before. I did not verify that they were 
accurate and that was my mistake.

Thank you for your input.

Original comment by scott.mu...@gmail.com on 1 Oct 2011 at 12:55

GoogleCodeExporter commented 9 years ago 
There were values after the 5.1.6 patch as before that had none at all. The 
wrong tables were just being pulled after I noticed your fix. If you didn't see 
values you sure your install is at 5.1.6?

Original comment by frozenic...@gmail.com on 1 Oct 2011 at 8:45