search

jetbrains-academy / rustlings-course

Small exercises to get you used to reading and writing Rust code!
https://github.com/rust-lang/rustlings/releases/tag/1.2.2
MIT License
149 stars 33 forks source link

Update Getting Started/External Linter #300

Closed tedzards509 closed 1 month ago

tedzards509 commented 2 months ago

The Settings page has been refreshed with Rust being a top level point. Also the checkbox has been updated. These changes reflect that.

kochaika commented 2 months ago

Hi! Thanks for the suggested fix!

The screenshot and instructions are oriented on using IntelliJ IDEA with Rust plugin. From that point of view, there is no mistake here.

I suggest not to change it, but to add a note in the task description that the path in the settings is different only for RustRover. (Settings / Preferences | Rust | External Linters)

This change is right for both IDEs.

RSully commented 1 month ago

I agree something needs to change here. I think it makes a lot more sense for these instructions to be tailored to RustRover and have a note about IntelliJ IDEA (the opposite of what you're proposing). I am learning Rust and it made the most sense to me to grab RustRover to have a purpose-built IDE for the language, rather than using IDEA and adding plugins.

kochaika commented 1 month ago

Yes, I agree. Do you want to make these changes in your PullRequest?

RSully commented 1 month ago

No I don't think this change makes sense to include in #301, that PR is for a different issue altogether

kochaika commented 1 month ago

@RSully Sorry, I answered in wrong thread

kochaika commented 1 month ago

Added more detailed fix here: https://github.com/jetbrains-academy/rustlings-course/pull/302

@tedzards509 Thank you for pointing that out