Validation failing for cdrom_type, disk_controller_type & disk_thin_provisioned.

jetbrains-infra / packer-builder-vsphere

Packer plugin for remote builds on VMware vSphere

Mozilla Public License 2.0

542 stars 175 forks source link

Validation failing for cdrom_type, disk_controller_type & disk_thin_provisioned. #188

Open Srini-B-GIT opened 5 years ago

Srini-B-GIT commented 5 years ago

I am using vsphere-iso plugin to to create rhel7.5 template vmware environment. template validation is failing with below ..

$ ./packer validate rhel75.json Template validation failed. Errors are shown below.

Errors validating build 'vsphere-iso'. 3 errors occurred:

unknown configuration key: "cdrom_type"
unknown configuration key: "disk_controller_type"
unknown configuration key: "disk_thin_provisioned"

values provided in rhel75.jason below and are picked like it based on the suggestion in https://github.com/jetbrains-infra/packer-builder-vsphere

 "cdrom_type": "ide",
  "disk_controller_type": "lsiLogic",
  "disk_thin_provisioned": "true",

so please suggest if these are correct .

Srini-B-GIT commented 5 years ago

After changing the parameters names validation is still failing .. any suggestions ?

unknown configuration key: "cdrom_adapter_type"
unknown configuration key: "disk_adapter_type"
unknown configuration key: "disk_thin_provisioned"

mkuzmin commented 5 years ago

please show the full file

jpgrall commented 5 years ago

I was also having the same issue with "disk_controller_type". I needed support for the four listed SCSI types from VMware. (BUSLOGIC, LSILOGIC, LSILOGICSAS, and PVSCSI). But then I found this doc and these values are accepted (lsilogic|buslogic|pvscsi|lsilogic-sas)

Created a PR https://github.com/jetbrains-infra/packer-builder-vsphere/pull/218

aaronk1 commented 4 years ago

Thank you @jpgrall ! That is hugely helpful. Could not find this anywhere in the documentation, nor in multiple guides around ESXi or Workstation as the govmomi values don't seem to match what's documented for other systems and also don't match what's in the VMX file. Why!?!?!?!

jonhowe commented 3 years ago

Thanks for the comments here folks, it helped me! Like you I spent an embarrassing amount of time thinking I was the issue. The above PR should fix that for others.