search

jetbridge / cdk-nextjs

Deploy a NextJS application using AWS CDK
https://constructs.dev/packages/cdk-nextjs-standalone
Apache License 2.0
260 stars 43 forks source link

Route53 ARecord Override props not being used #205

Closed patrickufer closed 4 months ago

patrickufer commented 4 months ago

Discussed in https://github.com/jetbridge/cdk-nextjs/discussions/204

props.overrides.aRecordProps is never actually passed into the creation of the ARecord (ditto for AAAARecord). Seems to me like it should though 🤔 https://github.com/jetbridge/cdk-nextjs/blob/v4.0.0-beta.25/src/NextjsDomain.ts#L168-L169

bestickley commented 4 months ago

@patrickufer, you're correct. Thanks for raising this issue. Could you create a PR? Thanks!