jetdog8808 / Avatar-Armature-Collider

Dynamicly fit colliders to avatars humanoid armature.
MIT License
34 stars 1 forks source link

collision with VRCObjectSync pickups problem #4

Closed Narazaka closed 5 months ago

Narazaka commented 5 months ago

If AvatarArmatureColliders collide with VRCObjectSync pickup objects, ownership does not transfer to the player who has that AvatarArmatureColliders. It is natural because AvatarArmatureColliders do not have VRCObjectSync and AllowCollisionOwnershipTransfer.

So collision with pickups whose owner is other player sometimes causes strange or unstable behavior.

jetdog8808 commented 5 months ago

the AvatarCollider script could add a SetOwner method in the OnCollisionEnter event. My main concern is the performance of calling GetComponentInParent for every event.

Narazaka commented 5 months ago

I see... Thank you to this so performant library. It is reasonable issue...

jetdog8808 commented 5 months ago

Another concern was kinematic colliders calling OnCollisionEnter for static colliders. Documentation shows it will only send events for dynamic colliders.

added a new component and option to toggle the ownership transfer: eeb807c432acf69103c97349905f65092546bee5