improve calculation of required size for svg container element for connectors (was: Flowchart Connectors incorrectly rendering)

jetersu / jsplumb

Automatically exported from code.google.com/p/jsplumb

0 stars 0 forks source link

improve calculation of required size for svg container element for connectors (was: Flowchart Connectors incorrectly rendering) #314

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

Connectors are not rendering correctly in Firefox or Chrome in certain 
scenarios when using the flowchart connector. It seems that the container for 
the lines does not give enough vertical space around the connector if the start 
of the connector is below or further right than the end of the connector. 

This does not seem to occur in IE9.

I have attached an image to show the problem, I am using version 1.3.16.

Original issue reported on code.google.com by mikeedwa...@googlemail.com on 30 Jan 2013 at 12:58

Attachments:

JSPlumbissue.png

GoogleCodeExporter commented 8 years ago

i can't reproduce this.   if you can supply a jsfiddle demonstrating the 
problem we can reopen. otherwise i'm marking it invalid for now.

(are you sure the connector is not going outside of the bounds of the element 
to which it is attached?)

Original comment by simon.po...@gmail.com on 6 Feb 2013 at 10:19

Changed state: Invalid

GoogleCodeExporter commented 8 years ago

Could you explain more about what you mean by the bounds of the element to 
which it is attached? If this the container for the flowchart or the shape that 
it connects on to? How are the bounds defined?

Original comment by mikeedwa...@googlemail.com on 7 Feb 2013 at 9:30

GoogleCodeExporter commented 8 years ago

i mean the parent element of the svg elements. is it fully contained within the 
parent element?  

it's odd that you don't see the behaviour in ie9.  can you reproduce this in a 
fiddle?

Original comment by simon.po...@gmail.com on 7 Feb 2013 at 9:44

GoogleCodeExporter commented 8 years ago

I have setup the problem: http://jsfiddle.net/S7Qvv/5/

Original comment by mikeedwa...@googlemail.com on 7 Feb 2013 at 10:28

GoogleCodeExporter commented 8 years ago

great, thanks.  reopening.  seems to be caused by the stub value of [5,5].  if 
you change it to [25,25] it renders fine.

Original comment by simon.po...@gmail.com on 7 Feb 2013 at 10:40

Changed state: Accepted
Added labels: 1.4.0

GoogleCodeExporter commented 8 years ago

Issue 309 has been merged into this issue.

Original comment by simon.po...@gmail.com on 11 Feb 2013 at 12:01

GoogleCodeExporter commented 8 years ago

i have merged issue 309 into this one as it is related: what is needed is a 
uniform way for jsplumb to determine what size the containing svg element needs 
to be.  this code is a little adhoc at the moment and spread out amongst the 
various connector types. it needs to be formalised.

Original comment by simon.po...@gmail.com on 11 Feb 2013 at 12:02

Changed title: improve calculation of required size for svg container element for connectors (was: Flowchart Connectors incorrectly rendering)

GoogleCodeExporter commented 8 years ago

Issue 319 has been merged into this issue.

Original comment by simon.po...@gmail.com on 15 Feb 2013 at 5:40

GoogleCodeExporter commented 8 years ago

Issue 319 has been merged into this issue.

Original comment by simon.po...@gmail.com on 15 Feb 2013 at 5:48

GoogleCodeExporter commented 8 years ago

Issue 321 has been merged into this issue.

Original comment by simon.po...@gmail.com on 18 Feb 2013 at 9:33

GoogleCodeExporter commented 8 years ago

Issue 321 has been merged into this issue.

Original comment by simon.po...@gmail.com on 20 Feb 2013 at 8:03

GoogleCodeExporter commented 8 years ago

this is done now. the painting has been optimised.

Original comment by simon.po...@gmail.com on 13 Mar 2013 at 9:34

Changed state: Fixed