jetersu / jsplumb

Automatically exported from code.google.com/p/jsplumb
0 stars 0 forks source link

canvas bounding box calculation not quite right #319

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Hi Simon,

I've spotted a possible issue in the canvas element calc that makes it expand 
further than it should when dragged. This effect can be observed on the jsPlumb 
website demo in canvas mode too.

I've attached 2 images showing the initial state of the bounding box and the 
dragged version which displays the expanded size of the box.

This seems to affect all of the line types, though inversely for the bezier one 
- bezier seems to start larger and become more accurate the further from the 
source you drag it.

This is only an issue where the canvas overlaps other elements that you intend 
for the user to interact with (re: the links at the bottom of the page in my 
images) - that issue can be sorted by setting a higher z-index for those 
elements though, so this isn't a huge issue.

Original issue reported on code.google.com by OMGtheCH...@gmail.com on 15 Feb 2013 at 12:56

Attachments:

GoogleCodeExporter commented 8 years ago
ahh couldnt see how to set a lower priority for this either, sorry.

Original comment by OMGtheCH...@gmail.com on 15 Feb 2013 at 12:59

GoogleCodeExporter commented 8 years ago
you really should set a higher z-index for your nodes than the connections 
anyway.  

i think i might merge this into issue 314, as it is kind of related, and i 
merged something like this in to 314 the other day.

Original comment by simon.po...@gmail.com on 15 Feb 2013 at 5:40

GoogleCodeExporter commented 8 years ago
no worries, Simon. Cheers for the response, and yeah I wondered if they might 
be related :)

Original comment by OMGtheCH...@gmail.com on 15 Feb 2013 at 5:46

GoogleCodeExporter commented 8 years ago
yeah i think in general it all just needs a little bit of tightening up. 

Original comment by simon.po...@gmail.com on 15 Feb 2013 at 5:48