SquishIt can't minify e5-shim

jetheredge / SquishIt

Lets you *easily* bundle some css and javascript! Check out the Google group if you have questions!

http://groups.google.com/group/squishit

MIT License

459 stars 119 forks source link

SquishIt can't minify e5-shim #313

Open drewfreyling opened 9 years ago

drewfreyling commented 9 years ago

Getting a javascript error: Unexpected token ,

Steps to repo:

Create a new mvc app
Install Squishit 0.9.8
Add https://github.com/es-shims/es5-shim/blob/v4.1.6/es5-shim.min.js to your scripts folder
Add the following bundle:

@(Bundle.JavaScript()
      .Add("~/Scripts/jquery-1.10.2.min.js")
      .Add("~/Scripts/es5-shim.min.js").ForceRelease().MvcRender("~/Scripts/main.js"))

Run it and you should get the error

AlexCuse commented 9 years ago

This is unlikely to be a SquishIt problem, try using the YUI minifier.

AlexCuse commented 9 years ago

I usually configure this globally in Application_Start

            Bundle.ConfigureDefaults()
                  .UseYuiForCssMinification()
                  .UseYuiForJsMinification()

drewfreyling commented 9 years ago

@AlexCuse I think it is a SquishIt issue because the version of ajaxmin is capped (AjaxMin (≥ 4.48.4489.28432 && ≤ 4.97.4951.28483) - so out of the box the maximum version of the minifier that is specified does not work.

AlexCuse commented 9 years ago

That is because there are breaking changes in ajaxmin past that version. I plan to update in v1.0. f you want to use a newer version in the meantime you can implement your own minifiers but I would suggest using YUI (this is going to be the default in 1.0)