search

jethrocarr / namedmanager

AGPL web-based DNS management interface in PHP
349 stars 126 forks source link

SQL: Don't create database #20

Open fbjerggaard opened 8 years ago

fbjerggaard commented 8 years ago

I don't think the sql script should create the database and/or use it - in my opinion it should be up to the user to create the database and import it correctly.

The reason I stumbled upon this issue is because when you are importing the database with puppet it complains about the multiple create statements.

Also, if the users want to name the database something else they should be allowed to do that

Would love to hear some opinions on this

jethrocarr commented 8 years ago

The current design is intended to make it easy for a user to RPM install and have a running app, but more than happy for any PRs that make this more configurable (or optional) whilst still allowing this easy default behaviour for those whom want it.

jethrocarr commented 8 years ago

Some related notes/context in #5

jethrocarr commented 8 years ago

A good fix could be moving the CREATE DATABASE step in the install.sql files into the resources/autoinstall.pl helper application, which would retain the default "easy mode" but also allow direct import of the install SQL to any DB.

fbjerggaard commented 8 years ago

That sounds like a perfect solution if you ask me