jethrocarr / namedmanager

AGPL web-based DNS management interface in PHP
351 stars 125 forks source link

Hostname Case Folding is Wrong According to the RFC #88

Open frankcrawford opened 4 years ago

frankcrawford commented 4 years ago

PR #85 probably breaches RFC 4343, in that Section 4.2 DNS Input Case Preservation states that

When a node in the DNS name tree is created by any of such inputs, no case conversion is done. Thus, the case of ASCII labels is preserved if they are for nodes being created.

However, all testing is case insensitive and when multiple entries created:

However, when a name label is input for a node that already exists in DNS data being held, the situation is more complex. Implementations are free to retain the case first loaded for such a label, to allow new input to override the old case, or even to maintain separate copies preserving the input case.

All this means that we shouldn't really be changing the case, but rather, implementing some case insensitive test.

What do others feel we should do?