control + r only works after I install fzf

[domoritz]

Right after I install fzf, I can use reverse search. However, as soon as I open a new session, it does not work any more until I uninstall and reinstall the fzf plugin. How can I help you to debug this?

[jethrokuan]

How are you installing the fzf plugin? This could be an issue of fzf not being in your path.

On 9 Mar 2017 11:51 AM, "Dominik Moritz" notifications@github.com wrote:

Right after I install fzf, I can use reverse search. However, as soon as I open a new session, it does not work any more until I uninstall and reinstall the fzf plugin. How can I help you to debug this?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/fisherman/fzf/issues/35, or mute the thread https://github.com/notifications/unsubscribe-auth/ABlxkQsOZXaJkqXaWZThqk53sOsbAI4eks5rj3c3gaJpZM4MXnbG .

[domoritz]

I'm on OSX and use homebrew to install fzf.

$ fzf --version
0.16.6
$ which fzf
/usr/local/bin/fzf

[jethrokuan]

Are you using fish, and did you install this wrapper? If so, how did you do it? I'm guessing you may be at the wrong repo

On 9 Mar 2017 12:08 PM, "Dominik Moritz" notifications@github.com wrote:

I'm on OSX and use homebrew to install fzf.

$ fzf --version 0.16.6 $ which fzf /usr/local/bin/fzf

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/fisherman/fzf/issues/35#issuecomment-285249273, or mute the thread https://github.com/notifications/unsubscribe-auth/ABlxkX-h9rCjw_F8oYNu-r761_BMU1_Oks5rj3svgaJpZM4MXnbG .

[domoritz]

Yes, I use fish, version 2.5.0 and fisherman version 2.12.0 ~/.config/fish/functions/fisher.fish. I installed this wrapper with fisher fzf.

What's funny is that reverse search in iTerm 2 version 3 works well when I uninstall this wrapper (fisher uninstall fzf) and then install it again.

In a new session, I can call fzf without problems but reverse search through this wrapper does not work. What also works is if I run __fzf_reverse_isearch directly.

[jethrokuan]

Are you receiving any errors when pressing Ctrl-R? This could be a fish + iTerm issue.

[domoritz]

No, no errors whatsoever. Simply nothing happens when I try to do a reverse search.

[jethrokuan]

Are you using vim keybindings? Could you try typing this into your terminal in the case where Ctrl-r doesn't work, and try Ctrl-r again?

bind \cr '__fzf_reverse_isearch'

[domoritz]

I don't think I am using vim keybinding. However, after I call bind \cr '__fzf_reverse_isearch' in the session, I can use reverse search again.

[jethrokuan]

Can you check if your config.fish does anything fishy, like bind C-r? That is, are you using fisherman to manage all your fish config? Your config.fish takes precedence over whatever fisherman manages.

On 10 Mar 2017 10:00 AM, "Dominik Moritz" notifications@github.com wrote:

I don't think I am using vim keybinding. However, after I call bind \cr '__fzf_reverse_isearch' in the session, I can use reverse search again.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/fisherman/fzf/issues/35#issuecomment-285550835, or mute the thread https://github.com/notifications/unsubscribe-auth/ABlxkRf5Rt7Zsu7ImjdJMCIM3BeZO2xZks5rkK7EgaJpZM4MXnbG .

[domoritz]

That was the right hint.

Somehow this command does not work anymore and it broke reverse search. Thank you @jethrokuan!

function fish_user_key_bindings
  bind \e\e 'thefuck-command-line'  # Bind EscEsc to thefuck
end

[domoritz]

For ref, I was using the suggestion from https://github.com/oh-my-fish/plugin-thefuck#optional-key-binding

[jethrokuan]

Fisherman modifies fish_user_key_bindings under the hood as well, so doing that would override all keybindings that fisherman tries to install for you. I believe the plugin you referenced has a fisherman-friendly version as well (:

On 10 Mar 2017 10:20 AM, "Dominik Moritz" notifications@github.com wrote:

For ref, I was using the suggestion from https://github.com/oh-my-fish/ plugin-thefuck#optional-key-binding

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fisherman/fzf/issues/35#issuecomment-285553816, or mute the thread https://github.com/notifications/unsubscribe-auth/ABlxkV9fe7EE_GnX6qStCCrdxcehiSQjks5rkLNngaJpZM4MXnbG .

[domoritz]

I only found the omf wrapper. Do you remember where you saw the fisherman-friendly version?

[jethrokuan]

Oh I saw wrong. I guess there isn't one, but making one would be a simple fork. I could do it, if you want.

On 10 Mar 2017 11:48 AM, "Dominik Moritz" notifications@github.com wrote:

I only found the omf wrapper. Do you remember where you saw the fisherman-friendly version?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/fisherman/fzf/issues/35#issuecomment-285565965, or mute the thread https://github.com/notifications/unsubscribe-auth/ABlxkVEn2mIYeAI0W4htWX9UYpO8leoGks5rkMgagaJpZM4MXnbG .

[domoritz]

That would be sweet. I like to use the esc+esc keybinding when I messed up a command. But typing fuck is also not a big deal.

[jethrokuan]

Done! fisher i jethrokuan/thefuck should do it.

the command seems pretty slow though.

[domoritz]

Awesome. It works well. You are right, it is slow but that's not a problem with your wrapper.

On Thu, Mar 9, 2017 at 10:23 PM Jethro Kuan notifications@github.com wrote:

Done! fisher i jethrokuan/thefuck should do it.

the command seems pretty slow though.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/fisherman/fzf/issues/35#issuecomment-285588503, or mute the thread https://github.com/notifications/unsubscribe-auth/AAj86nVWopNxBCbSHSykSfko6GB4s2B7ks5rkOxIgaJpZM4MXnbG .