search

jethrokuan / fzf

Ef-🐟-ient fish keybindings for fzf
MIT License
861 stars 66 forks source link

Fallback using "contains" if argparse does not exist (Fish shell v<2.7) #87

Closed frbor closed 6 years ago

frbor commented 6 years ago

I failed to use open/preview with fzf with Fish shell version 2.4.0, because argparse was used, which was not introduced until Fish version 2.7.

I managed to create a fallback version using contains, which works for me, so I hope you will consider this PR.

jethrokuan commented 6 years ago

This looks like a fine fallback approach. There's another file with usage of argparse, __fzf_cd.fish. Perhaps you could update that too?

frbor commented 6 years ago

Sure! I have updated __fzf__cd.fish as well.

jethrokuan commented 6 years ago

Thanks!