search

jethrokuan / z

Pure-fish z directory jumping
MIT License
1.26k stars 44 forks source link

Stop allowing configurable z and zo commands #109

Closed ismay closed 11 months ago

ismay commented 2 years ago

This implements what we discussed here: https://github.com/jethrokuan/z/issues/107#issuecomment-1085674474. By moving to a static command we can ship the command and its completions in the format that fisher expects. This isn't just useful for fisher, it also works better with fish. By shipping static commands fish can lazy load both the commands and their completions. This means we don't have to run setup for this in conf.d scripts. It also simplifies the code a little bit.

Users can still easily create an alias fn, which is the canonical fish way of renaming a command. That way, even if they want to alias the command they can still retain the lazy loading.

Also, I took a look with grep.app, and could find only two users who were using a custom z command: see here. So this seems ok to change if we want to.

ismay commented 2 years ago

I've rebased on master. I think all that's left now is to regenerate the man pages. Do we have to do that manually?