search

jethrokuan / z

Pure-fish z directory jumping
MIT License
1.26k stars 44 forks source link

Add missing newline chars in printf(1)-ed strings #69

Closed ghost closed 5 years ago

ghost commented 5 years ago

As printf(1) does not add a newline character after printing a string, as echo(1) does, this character must be explicitly added. I don't know if the author was using echo(1) before and decided to use printf(1) for portability purposes but forgot to add the newlines, so I'm adding them.

And my conscience was dictating me to do it, as I was enraged by the amount of return chars it was generating while I was learning the tool :joy:

jethrokuan commented 5 years ago

Hah this is probably related to https://github.com/jethrokuan/z/pull/68/ as well.

Not sure why I've never seen issues with not printing the newline char, and what's different between our systems such that it affects your use.