jetify-com / devbox-install-action

31 stars 15 forks source link

Restores the tar command to its original state #21

Closed LucilleH closed 11 months ago

LucilleH commented 11 months ago

What

This PR tries to reduce side effects by:

Why

We are using chmod u+s "$(command -v tar)" to setuid on tar (This is needed because we are caching /nix/ and other directories outside of ~, which is owned by root)

This has a problem where it changes the parent directory of ~/.cache/nix to be owned by root instead of runner.

I thought https://github.com/jetpack-io/devbox-install-action/pull/22 had fixed it, but we ran into similar issues when we use a go cache on top of the devbox cache.

Caveat

Cache enabled on self hosted Linux may stop working

LucilleH commented 11 months ago

@gcurtis verified with https://github.com/jetpack-io/axiom/actions/runs/6268714473/job/17024088430?pr=3399