[plugins] support reading (and discarding) comments plugin.json files

[savil]

Summary

Fixes #1911

This PR cleans the json-file-content of comments before processing it as "json content" i.e. we discard the comments prior to invoking existing logic for ingesting the plugin.json file.

This PR relies on Devbox not programmatically modifying the plugin.json. For now, users hand edit the plugin.json files. This is different from devbox.json which we do programmatically modify due to devbox add, devbox rm and similar commands, and so need to keep track of the json-with-comments' AST.

How was it tested?

To test, I added comments to the following:

1. local plugin example
2. a builtin plugin (python)

I did NOT test remote Github plugin. But I tried to modify its code path. Did i get it right?

[savil]

• #1924
• #1923 👈
• #1922
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @savil and the rest of your teammates on Graphite

[savil]

I did NOT test remote Github plugin. But I tried to modify its code path. Did i get it right?

You can use the devbox repo and test with example plugins?

pushed this github repo with comments in the plugin.json: https://github.com/savil/devbox-plugin-example-with-spaces-/blob/main/plugin.json#L13-L18

works once I modify examples/v2-github/devbox.json to use this one

[sentry-io[bot]]

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

• ‼️ syscall.Errno: error reading devbox.json: <redacted errors.withStack>: <redacted errors.withStack>: <redacted ... go.jetpack.io/devbox/internal/plugin in (*Local... View Issue
• ‼️ *syscall.Errno: <redacted errors.withStack>: <redacted errors.withStack>: <redacted fs.PathError>: <redacted s...* `go.jetpack.io/devbox/internal/plugin in (Local...` View Issue

_{Did you find this useful? React with a 👍 or 👎}