[plugins] Fix rm for packages with __remove_trigger_package - Githubissues

jetify-com / devbox

Instant, easy, and predictable development environments

https://www.jetify.com/devbox/

Apache License 2.0

8.61k stars 197 forks source link

[plugins] Fix rm for packages with __remove_trigger_package #1940

Closed mikeland73 closed 7 months ago

mikeland73 commented 7 months ago

Summary

Fixes issue where user could not remove package that is replaced by a flake in plugin (uses __remove_trigger_package)

Fixes https://github.com/jetpack-io/devbox/issues/1936

We need two different functions for packages:

AllPackages which is used for instalation and lock file. Includes packages added/removed by plugins.
TopLevelPackages is only what is in root devbox.json

How was it tested?

Tested manually
Added php to rm unit test