jetify-com / devbox

Instant, easy, and predictable development environments
https://www.jetify.com/devbox/
Apache License 2.0
7.94k stars 191 forks source link

[bug-fix] Fix lockfile rewrite and added devbox list command #2007

Closed mikeland73 closed 2 months ago

mikeland73 commented 3 months ago

Summary

The source of this bug is that when calling lockfile.Tidy() we were passing in only top level packages and not including plugin packages as well.

This bug was also affecting dev container construction and some edge case plugin template logic. This bug only affects users that are using custom plugins with packages.

I renamed PackageNames to AllPackageNamesIncludingRemovedTriggerPackages to make very unambiguous. Also removed a redundant function in config package that was no longer needed.

Added devbox list command for testing and decided to keep it in.

How was it tested?

In other project added golang monorepo plugin and logged to ensure Tidy was not recreating lockfile. Also tested adding go to that project.

sentry-io[bot] commented 2 months ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎