jetify-com / devbox

Instant, easy, and predictable development environments
https://www.jetify.com/devbox/
Apache License 2.0
7.83k stars 187 forks source link

Add new --pcflags option to devbox services up #2111

Closed josh-d2 closed 1 month ago

josh-d2 commented 1 month ago

Summary

Add new --pcflags option which provides flags directly to process-compose

Motivation

https://github.com/jetify-com/devbox/issues/2105

Usage

The --pcflags flag must be provided in front of each flag as shown below:

devbox services up ${service} \
--pcflags ${flag1} \
--pcflags ${flag2} \
...

How was it tested?

  1. Added debugging print statement in manager.go, right before providing the flags to process-compose, to ensure that the flags are being passed down as expected to process-compose.
  2. Verified that devbox services up nginx shows the process-compose UI but devbox serviecs up nginx --pcflags -t=false does not show the UI.
sentry-io[bot] commented 1 month ago

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

Did you find this useful? React with a 👍 or 👎