search

jetify-com / devbox

Instant, easy, and predictable development environments
https://www.jetify.com/devbox/
Apache License 2.0
7.83k stars 187 forks source link

[docker] fix docker release image #2136

Closed mohsenari closed 2 weeks ago

mohsenari commented 3 weeks ago

Summary

This PR addresses the issue of our previous approach to only publish the latest version of devbox with :latest tag in dockerhub. It achieves 2 things:

  1. fixes the previously broken github action to release a docker image after every tag creation.
  2. updates the dockerfile so that devbox binary doesn't automatically upgrade to latest version upon first use. This allows docker pulls have fixed versions.

How was it tested?

Already tested on releasing 0.10.7 version to dockerhub as test.

mohsenari commented 3 weeks ago

Updated the PR based on huddle discussion with @mikeland73 The new approach is to set latest tag to false and remove replacing the launcher logic. In a follow up PR I'll add a job to update latest tag as well.