jetify-com / devbox

Instant, easy, and predictable development environments
https://www.jetify.com/devbox/
Apache License 2.0
8.37k stars 196 forks source link

`python`'s `plugin_version` is overriden in lock with devbox 0.13.0 #2294

Open guillermoz-nutanix opened 1 week ago

guillermoz-nutanix commented 1 week ago

What happened?

After upgrading to 0.13.0, and running devbox shell (or devbox install in our CI), the devbox.lock was modified with this diff

diff --git a/devbox.lock b/devbox.lock
index 03cbb2524d..bd2020311e 100644
--- a/devbox.lock
+++ b/devbox.lock
@@ -524,7 +524,7 @@
     },
     "python@3.12.2": {
       "last_modified": "2024-03-08T13:51:52Z",
-      "plugin_version": "0.0.3",
+      "plugin_version": "0.0.4",
       "resolved": "github:NixOS/nixpkgs/a343533bccc62400e8a9560423486a3b6c11a23b#python312",
       "source": "devbox-search",
       "version": "3.12.2",

Steps to reproduce

  1. With devbox 0.12.0 install python
  2. Upgrade devbox to 0.13.0
  3. Run devbox install.

EDIT: I'm also able to repro the issue by running DEVBOX_USE_VERSION=0.12.0 devbox install, with versions 0.12.0 and 0.13.0. The plugin_version is set to 0.0.3 by 0.12.0 and 0.0.4 by 0.13.0.

Command

install, shell

devbox.json

{
  "packages": [
    "kubectl@1.28.4",
    "python@3.12.2",
    "lsof@latest",
    "gh@latest",
    "xdg-utils@latest",
    "jq@latest",
    "nodejs@20.10.0",
    "chart-testing@3.10.1",
    "kind@0.22",
    "kubernetes-helm@3.14.3"
  ],
  "shell": {
    "init_hook": [
      ". ./scripts/initialize.sh"
    ],
    "scripts": {
      "test": [
        "echo \"Error: no test specified\" && exit 1"
      ]
    }
  }
}

Devbox version

0.13.0

Nix version

2.18.1

What system does this bug occur on?

Linux (x86-64)

Debug logs

No response

djgoku commented 1 week ago

This is working as intended. The plugin was updated between 0.12.0 and '0.13.0`.

https://github.com/jetify-com/devbox/commit/6df893aad7550c191d876f6edb94df93a61d2adb#diff-b6b6fe9ddb1de4adddfb1ce9180cf19fb2a67cc72cfb38197e7abfca05fbf469R3