jetify-com / devbox

Instant, easy, and predictable development environments
https://www.jetify.com/devbox/
Apache License 2.0
8.82k stars 207 forks source link

patchpkg: use devbox flake instead of local binary #2378

Closed gcurtis closed 4 weeks ago

gcurtis commented 4 weeks ago

Update the patching flake to use the devbox flake (added in 37c36a1b) instead of copying the binary manually.

When Devbox needs to patch a package, it generates a flake that calls devbox patch as its builder. Because flake builds are sandboxed, we need a way of getting devbox into the Nix store.

Previously, we were just copying the currently running devbox executable into the Nix store and using that. However, Devbox isn't actually a static binary (we don't build with CGO_ENABLED=0). This causes devbox patch to fail because the flake is isolated from the system's linker.