search

jetlfj / pe

0 stars 0 forks source link

Incorrect hyperlink in DG #9

Open jetlfj opened 1 year ago

jetlfj commented 1 year ago

image.png

MainApp links to the original AB3's MainApp.java instead of your team repo's one. This may confuse developers when they end up navigating to a different code base.

soc-se-bot commented 1 year ago

Team's Response

This is the link for the MainWindow AB3: https://github.com/se-edu/addressbook-level3/tree/master/src/main/java/seedu/address/Main.java

This is the correct link from the tp: https://github.com/AY2223S1-CS2103T-T09-4/tp/tree/master/src/main/java/seedu/address/Main.java

It can be seen that simply replacing the front part of the link would lead to a valid URL so they are the same bug (aka the original link not being updated) as 2726.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

More incorrect hyperlinks in DG

Note from the teaching team: This bug was reported during the Part II (Evaluating Documents) stage of the PE. You may reject this bug if it is not related to the quality of documentation.

image.png

Both MainWindow and MainWindow.fxml link to the original AB3's repo instead of your own.

[original: nus-cs2103-AY2223S1/pe-interim#3558] [original labels: type.DocumentationBug severity.Low]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: image.png

These two bugs do not fall under either of the above two cases to be considered as duplicates.

(a) They are not the exact same bug, even if they are the same kind of bug. The "original" bug is wrong hyperlinks to MainWindow.java and MainWindow.fxml while this is a wrong hyperlink to MainApp.java.

(b) They can be fixed independently, as seen by multiple correct links across the rest of the DG. You can fix one without fixing the other.

As such, this report should not be classified as a duplicate.

image.png

Also, your response is also erroneous. Firstly, I reported that the wrong hyperlink is to MainApp.java, not Main.java. Next, you provided a link to Main.java while saying that it is a link to MainWindow.