search

jetmore / swaks

Swaks - Swiss Army Knife for SMTP
http://jetmore.org/john/code/swaks/
GNU General Public License v2.0
848 stars 86 forks source link

add --smtputf8 support #20

Closed wolfgangkarall closed 3 months ago

wolfgangkarall commented 4 years ago

Hi John,

this is just adding support for the SMTPUTF8 parameter in the MAIL command, closely following the change in 9ce718120f105dc56a4766ee4d001ffc9e5f8277 for --prdr support.

Cheers Wolfgang

augmentedfourth commented 4 months ago

@jetmore This is a great patch. Is there a reason it didn't get added in v20240103.0?

jetmore commented 4 months ago

@augmentedfourth (great username) no specific reason beyond time. It's not just accepting the PR, it's making sure I understand the problem space and the fix, adding testing, and feeling comfortable enough to be responsible for the implementation moving forward. I'll add it to the next milestone for consideration though

augmentedfourth commented 4 months ago

Ok, cool. I've manually applied this patch to a more recent version a couple of different times now, to test internationalization for the systems/platform at $WORK. Given how infrequently swaks has new releases, I was hoping to see it merged in last month's update.

polarathene commented 4 months ago

It's not just accepting the PR, it's making sure I understand the problem space and the fix, adding testing, and feeling comfortable enough to be responsible for the implementation moving forward

If you have any queries regarding the XOAUTH2 PR, feel free to ping me. I am reasonably familiar with it after my involvement with support in DMS and curl.

jetmore commented 3 months ago

I pulled this into a local branch to tweak it a little, but I intend that this will be supported in the next release, thank you @wolfgangkarall