jetmore / swaks

Swaks - Swiss Army Knife for SMTP
http://jetmore.org/john/code/swaks/
GNU General Public License v2.0
847 stars 86 forks source link

Prefixing filenames with '@' in --attach leads to @ being included in attachement filename. #55

Closed jen-Ya closed 7 months ago

jen-Ya commented 1 year ago

*** DEPRECATION WARNING: Inferring a filename from the argument to --attach will be removed in the future. Prefix filenames with '@' instead.

Prefixing filenames with '@' in --attach leads to @ being included in attachement filename.

/usr/bin/swaks --attach @test.txt ...

image
jetmore commented 7 months ago

No tests picked this up because all tests use a path

mb 0 /Users/jetmore/Documents/git/swaks/testing/regressions > ../../swaks --attach @t.txt -t foo --dump --dump data | grep t.txt
Content-Type: application/octet-stream; name="@t.txt"
Content-Description: @t.txt
Content-Disposition: attachment; filename="@t.txt"
mb 0 /Users/jetmore/Documents/git/swaks/testing/regressions > ../../swaks --attach @./t.txt -t foo --dump --dump data | grep t.txt
Content-Type: application/octet-stream; name="t.txt"
Content-Description: t.txt
Content-Disposition: attachment; filename="t.txt"
jetmore commented 7 months ago

Thanks for reporting. Fixed by #62, will be in the next release