jetperch / pyjoulescope_ui

Joulescope graphical user interface
https://www.joulescope.com
Apache License 2.0
75 stars 23 forks source link

Sidebar icons do not update on color scheme change #183

Open mliberty1 opened 1 year ago

mliberty1 commented 1 year ago

Joulescope model

JS220, JS110

UI version

1.0.9

What OS are you seeing the problem on?

Windows 11

What happened?

When changing the current view's "color_scheme" from "dark" to "light", the setting change works. For example, the waveform widget updates correctly. However, the sidebar icons do not update.

What was expected?

The sidebar icons should update to the correct color scheme.

How to reproduce?

  1. Click the sidebar Settings icon
  2. Select View → color_scheme and select the other one (Dark background → Light background in my case)
  3. Close the Settings widget
  4. Note that some sidebar icons may not have updated, like this:

image

Extra information

All icons are generated to the same locations with the same filenames. The software (or QT) could potential have a race condition between the QSS update and new icons availability and/or caching.

mliberty1 commented 1 year ago

Several workarounds:

  1. Select another view, then select this view.
  2. Close the UI and restart.