search

jetperch / pyjoulescope_ui

Joulescope graphical user interface
https://www.joulescope.com
Apache License 2.0
75 stars 23 forks source link

JLS v2 open does not work #190

Closed mliberty1 closed 1 year ago

mliberty1 commented 1 year ago

Joulescope model

JS220

UI version

1.0.17

What OS are you seeing the problem on?

Windows 11

What happened?

When opening a JLS v2 file, nothing happens, and the waveform view showing the file does not appear.

What was expected?

We should see the JLS v2 waveform after opening the file.

How to reproduce?

  1. File → Open
  2. Select any JLS v2 recording, click OK
  3. Nothing happens

Extra information

The pubsub changes in 1.0.17 broke JLS v2 open. However, once that is fixed, I still see a problem with long JLS v2 recordings. Short recordings open correctly, but an overnight capture does not open with an error.

mliberty1 commented 1 year ago

Commit d269d790c7c98557169bc46c5de224377f129610 combined with the upcoming pyjls 0.6.4 should address this issue. Testing is ongoing.

mliberty1 commented 1 year ago

Fixed in 1.0.18