search

jetperch / pyjoulescope_ui

Joulescope graphical user interface
https://www.joulescope.com
Apache License 2.0
85 stars 26 forks source link

Improve JLS file open by extension association. #205

Closed mliberty1 closed 1 year ago

mliberty1 commented 1 year ago

UI version

1.0.23

Your idea

The Joulescope UI installer registers the .jls file extension to open with the Joulescope UI. In 1.0.23, opening by extension:

  1. Opens a new Joulescope UI instance
  2. Switches to the File view
  3. Adds a new Waveform widget. The location is determined by the Qt Advanced Docking System defaults.

Unfortunately, this has a few problems. If the user just closes the UI and then opens another JLS file by extension, they see both files, and the new one tends to be a vertically short waveform at the top.

The default open-by-extension behavior should be one of:

  1. Open a new Joulescope UI that is only a JLS viewer. Ignore all other views, and do not save the configuration at the end.
  2. Open in the existing Joulescope UI instance, if available. This likely requires starting a process, discovering the open Joulescope UI instance, and forwarding the file path.

We could even have a setting allowing the user to customize the behavior.

Reference

https://forum.joulescope.com/t/feature-request-one-view-per-file/613

mliberty1 commented 1 year ago

Added file viewer mode to 1.0.27