jetperch / pyjoulescope_ui

Joulescope graphical user interface
https://www.joulescope.com
Apache License 2.0
75 stars 23 forks source link

Add language selection method #273

Open mliberty1 opened 4 weeks ago

mliberty1 commented 4 weeks ago

Joulescope model

JS220

UI version

1.1.9

Your idea

The Joulescope UI introduced language translations in 1.1. The language defaults to the system language. The user can select a different language by setting the LANG_JOULESCOPE_UI.

We have feedback from a few customers who have the OS language localized but would like to run the Joulescope UI in English. While this is possible with the environment variable, it requires extra steps. The process is documented in the UI User's Guide, but no one reads that ;)

It would be better if the UI had a dialog or some approach to select the language. It could display when the UI first launches or on request.

It would be ideal if the language could change dynamically. Unfortunately, without a LOT of work, the Joulescope UI has to restart to change the language.

madmatt55 commented 1 week ago

Language change UI is absolutely mandatory. With the current state of e.g. the german translation, I would suggest defaulting to english, it is in very bad shape and does not represent professional software quality.

mliberty1 commented 1 week ago

It sounds like the DeepL AI translations for German were particularly bad. We have already made some changes based on feedback that will improve our future UI releases.

In the meantime, you can change the UI language. Set the system environment variable LANG_JOULESCOPE_UI to en. In Windows, you can type "Edit environment variables" into the search box to bring up the control panel for this. For more details, see Section 8 of the Joulescope UI User's Guide.

atsju commented 1 week ago

@madmatt55 I'm having a look at German translation. https://github.com/jetperch/pyjoulescope_ui/pull/275 It's really long to do it all. I had 1 hour for 500lines only. ChatGPT seems to do well wen dirrected. Please have a quick review. I'm not native speaker so it's quite difficult even with a good level. Please confirm following of my pain points: