Get back to versioned awscr-s3 dependency

jetrockets / shrine.cr

File Attachment toolkit for Crystal applications. Heavily inspired by Shrine for Ruby.

https://jetrockets.github.io/shrine.cr/

MIT License

74 stars 16 forks source link

Get back to versioned awscr-s3 dependency #23

Closed stephendolan closed 3 years ago

stephendolan commented 3 years ago

Now that it appears as though this dependency supports Crystal 1.0 (https://github.com/taylorfinnell/awscr-s3/pull/94), we should move back off of the master branch so that other libraries using specific versions won't conflict.

stephendolan commented 3 years ago

@igor-alexandrov Just tagging you in case this had fallen off of the radar! Is this something we could look into getting merged, or at least enable the CI workflows for to see if they pass with the latest shard version?

igor-alexandrov commented 3 years ago

Tried locally, but getting an error:

In src/shrine/storage/s3.cr:57:18

 57 | uploader.upload(bucket, object_key(id), io, options)
               ^-----
Error: instantiating 'Awscr::S3::FileUploader#upload(String, String, IO+, Hash(String, String))'

In lib/awscr-s3/src/awscr-s3/file_uploader.cr:32:13

 32 | if io.size < UPLOAD_THRESHOLD
            ^---
Error: undefined method 'size' for IO::ARGF (compile-time type is IO+)

igor-alexandrov commented 3 years ago

@stephendolan thanks for this!