search

jetsgit / spree_tax_cloud

Spree Interface for TaxCloud SOAP API
19 stars 32 forks source link

Avoid setting nil amount if tax calculation is NaN. #28

Closed rterbush closed 11 years ago

rterbush commented 11 years ago

Not sure that this is the correct solution, but it does solve the problem of nil adjustments getting created in Spree.

This problem was first discovered when removing the last item from the cart using the 'X' delete. Feels like this is an indication of some other problem upstream.

This addresses issue reported on spree/spree: https://github.com/spree/spree/issues/3348

JDutil commented 11 years ago

@rterbush could you close this out in favor of my pr https://github.com/bluehandtalking/spree_tax_cloud/pull/29

rterbush commented 11 years ago

Closed in favor of @jdutil fix #29