jetsgit / spree_tax_cloud

Spree Interface for TaxCloud SOAP API
19 stars 32 forks source link

Tax values should be rounded better. #38

Closed JDutil closed 11 years ago

JDutil commented 11 years ago

I received an error report of an error where the tax amount wasn't rounded to an appropriate precision for Postgres:

Error Message: ActiveRecord::StatementInvalid: PG::NumericValueOutOfRange: ERROR: numeric field overflow DETAIL: A field with precision 8, scale 5 must round to an absolute value less than 10^3. : INSERT INTO "spree_tax_cloud_cart_items" ("amount", "created_at", "index", "line_item_id", "price", "quantity", "ship_total", "sku", "tax_cloud_transaction_id", "tic", "type", "updated_at") VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12) RETURNING "id"

Unfortunately I don't really much more info than that other than it happened during tax lookup of checkout process. Will try to dig into it some more if it's a recurring problem that I can get a better error trace on to figure out where we need to adjust the precision.

jetsgit commented 11 years ago

I would guess this is in relation to #34 being merged. Did not check, but it could be the table created does not account for the precision in #34

JDutil commented 11 years ago

Yes it appears that I need the fix from #34 as it isn't in the 2-0-stable branch that I'm using. Could you cherry-pick it over.

jetsgit commented 11 years ago

@jdutil , done.

JDutil commented 11 years ago

thanks