search

jetsgit / spree_tax_cloud

Spree Interface for TaxCloud SOAP API
19 stars 32 forks source link

Spree 2.2.x updates but still calculates on order rather than line items... #46

Closed JDutil closed 10 years ago

JDutil commented 10 years ago

......

jetsgit commented 10 years ago

@JDutil, evidently this did not solve the problem. I was just looking at this today and noted the changes from 2.1 to 2.2.

Although 

adjustment.originator = tax_cloud_transaction

is now 

adjustment.source    = tax_cloud_transaction

...that is not enough to get up to 2-2-stable (beta).

Here is Gist of changes in adjustment.rb

Reading in adjustment.rb, it mentions:

Once an adjustment is closed, it will not be automatically updated.

Not sure how that affects spree_tax_cloud, would it mean that update! would need to be called within spree_tax_cloud now??

Did this merge work for you? Seems to be an open issue at this point in regard to 2-2-stable.

Also noticed the new column in spree_orders in for tax_total. Is tax_total now computed with a different method?

JDutil commented 10 years ago

It appears to be working fine for me, but I didn't really get into the details of the adjustment opening/closing. There are certainly more changes that need to take place in order to get this extension fully compliant with spree 2.2.x as it uses line item adjustments instead of order adjustments now. I've still left things to only create an order adjustment, but we should now be making a line item adjustment for each TaxCloudCartItem