Closed brchristian closed 10 years ago
@jetsgit If this is looking good to you, I think we should be able to bring these three commits into the master
and 2-2-beta
branches as well. Let me know if that sounds good to you.
@brchristian, yes. More TBD to bring into Admin? Migration to add tic to product?
@jetsgit I think this should be complete -- If your app is on the latest 2-1-stable that includes these commits then you can run rake railties:install:migrations
to pull the migration for product TICs into your Spree app.
Admin?
@jetsgit There should be a TaxCloud TIC
field appearing in the Admin view of individual products. It will show the global product TIC grayed-out by default, and allow you to override that if you wish.
@brchristian, sounds good. Found the migration
@brchristian, not enough coffee when first looked at this, it's all there including updating spec. Yes, please submit PR for master and 2-2-beta.
@jetsgit Haha, no problem -- know the feeling well. I'll get that together now.
This branch provides support for Product-level TICs.
Product TICs default to
nil
and fall back to the globalSpree::Config.taxcloud_default_product_tic
setting, so this is fully backwards compatible and no additional configuration is necessary unless desired.