search

jetsgit / spree_tax_cloud

Spree Interface for TaxCloud SOAP API
19 stars 32 forks source link

Support for Product-level TICs #60

Closed brchristian closed 10 years ago

brchristian commented 10 years ago

This branch provides support for Product-level TICs.

Product TICs default to nil and fall back to the global Spree::Config.taxcloud_default_product_tic setting, so this is fully backwards compatible and no additional configuration is necessary unless desired.

brchristian commented 10 years ago

@jetsgit If this is looking good to you, I think we should be able to bring these three commits into the master and 2-2-beta branches as well. Let me know if that sounds good to you.

jetsgit commented 10 years ago

@brchristian, yes. More TBD to bring into Admin? Migration to add tic to product?

brchristian commented 10 years ago

@jetsgit I think this should be complete -- If your app is on the latest 2-1-stable that includes these commits then you can run rake railties:install:migrations to pull the migration for product TICs into your Spree app.

jetsgit commented 10 years ago

Admin?

brchristian commented 10 years ago

@jetsgit There should be a TaxCloud TIC field appearing in the Admin view of individual products. It will show the global product TIC grayed-out by default, and allow you to override that if you wish.

jetsgit commented 10 years ago

@brchristian, sounds good. Found the migration

jetsgit commented 10 years ago

@brchristian, not enough coffee when first looked at this, it's all there including updating spec. Yes, please submit PR for master and 2-2-beta.

brchristian commented 10 years ago

@jetsgit Haha, no problem -- know the feeling well. I'll get that together now.

brchristian commented 10 years ago

@jetsgit I know @radar has a GitHub flow for merging a PR into multiple branches at once, but personally I don't know how to do that using the GitHub interface and a few minutes of Googling didn't turn anything up. So, I've simply submitted separate PRs for the 2-2 branch and master branch.