search

jetsgit / spree_tax_cloud

Spree Interface for TaxCloud SOAP API
19 stars 32 forks source link

Exception when going to the tax cloud admin page #63

Closed MattFenelon closed 10 years ago

MattFenelon commented 10 years ago

I'm getting the following exception when visiting the tax cloud admin page.

ActionView::Template::Error (undefined method `taxcloud_origin' for #<Spree::AppConfiguration:0x007f41796e0d68>):
    1: <%= render :partial => 'spree/admin/shared/configuration_menu' %>
    2: <% origin = JSON.parse( Spree::Config.taxcloud_origin )  %>
    3:
    4: <h1><%= t('taxcloud_settings') %></h1>
    5:
  /home/vagrant/.rbenv/versions/2.1.1/lib/ruby/gems/2.1.0/bundler/gems/spree-af15e0a2231f/core/app/models/spree/preferences/configuration.rb:66:in `method_missing'
  /code/spree_tax_cloud/app/views/spree/admin/tax_cloud_settings/show.html.erb:2:in `_7e5095cdf8ee50e6a3f871a0543262e3'
  actionview (4.1.4) lib/action_view/template.rb:145:in `block in render'

I can't find a reference to taxcloud_origin anywhere in the repo. Looking through the commit history I noticed that taxcloud_origin was removed in a8ac9589dfeb13f9ca0f066a07c10f1cf043e7d0. I'd submit a PR to fix the issue but I'm not sure what the intention was behind removing it.

jetsgit commented 10 years ago

I'll push up a fix for this. Origin now based on shipping origin, those changes lost during a merge

jetsgit commented 10 years ago

Shipping location now used for product origin