Allow for building with opencv_contrib

jetsonhacks / buildOpenCVTX2

Build and install OpenCV for the NVIDIA Jetson TX2

MIT License

276 stars 153 forks source link

Allow for building with opencv_contrib #24

Open thepaulm opened 5 years ago

thepaulm commented 5 years ago

This is needed for things like ArUco fiducial marker support
Build like this: WITH_OPENCV_CONTRIB=YES ./buildOpenCV.sh
Version defaults to the OpenCV version

yarons commented 5 years ago

I tried your patch and got:

CMake Error at cmake/OpenCVModule.cmake:352 (message):
  Duplicated modules NAMES has been found
Call Stack (most recent call first):
  cmake/OpenCVModule.cmake:370 (_assert_uniqueness)
  modules/CMakeLists.txt:7 (ocv_glob_modules)

Some sort of duplication which I managed to solve by deleting the folders inside modules which doesn't make any sense (I deleted the one before the error repeatedly).

thepaulm commented 5 years ago

I went back and tried this and I'm getting the same thing you are. I don't really understand how I wasn't seeing this before, other than a guess that it wasn't happening because I wasn't starting from a fresh checkout.

I looked at where it's throwing these errors and I don't understand what cmake is attempting to do right there. I'll look at this as I find time. Thanks for pointing this out.

dmicha02 commented 5 years ago

It seems that the opencv-contrib version is not the same as opencv (3.4.1 for Jetson). Your script try to install opencv-contrib 4. Specify the particular version of opencv-contrib in your shell script.