jetstack / cert-manager-nginx-plus-lab

Lab demonstrating cert-manager, nginx-plus and Venafi
Apache License 2.0
19 stars 9 forks source link

Warning: "you already have Docker installed, this script can cause trouble" may confuse attendees #26

Closed wallrj closed 4 years ago

wallrj commented 4 years ago

When I follow the instructions in the README, using the cloudshare environment, I get this warning.

./setup-k8s.sh 
Installing docker...
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100 13328  100 13328    0     0  77040      0 --:--:-- --:--:-- --:--:-- 77040
# Executing docker install script, commit: 442e66405c304fa92af8aadaa1d9b31bf4b0ad94
Warning: the "docker" command appears to already exist on this system.

If you already have Docker installed, this script can cause trouble, which is
why we're displaying this warning and provide the opportunity to cancel the
installation.

If you installed the current Docker package using this script and are using it
again to update Docker, you can safely ignore this message.

You may press Ctrl+C now to abort this script.
+ sleep 20

After 20 seconds, the script continues. But it would be better if checked docker version (or something) and if successful, skipped the installation altogether.