search

jetstack / cert-manager-nginx-plus-lab

Lab demonstrating cert-manager, nginx-plus and Venafi
Apache License 2.0
19 stars 9 forks source link

Only use NGINX open source ingress #46

Closed wallrj closed 4 years ago

wallrj commented 4 years ago

We decided on Friday to only use the open source versions of NGINX and NGINX ingress. This will remove the complexity of distributing Nginx Plus licence keys.

We'll use the OSS Nginx ingress by Nginx Inc.

Currently the instructions contain scripts for setting up either nginx OSS or nginx plus ingress, so we can instruct attendees to run the OSS script.

But the instructions also contain a step which creates and nginx plus docker image for the workload. But there are no alternative instructions for using the OSS version.

Additionally the repo is still called cert-manager-nginx-plus-lab, which may cause confusion, so we should probably add a note at the top of the README explaining that the lab can be completed using either the OSS or the Plus versions.

wallrj commented 4 years ago

We've compromised and removed the nginx-pls workload while still allowing attendees to choose between nginx and nginx-plus ingress. See https://github.com/jetstack/cert-manager-nginx-plus-lab/pull/47