search

jetstack / cert-manager-nginx-plus-lab

Lab demonstrating cert-manager, nginx-plus and Venafi
Apache License 2.0
19 stars 9 forks source link

Clearer instructions on using NGINX OSS vs NGINX Plus #47

Closed wallrj closed 4 years ago

meyskens commented 4 years ago

Looks good! Just one tiny comment

meyskens commented 4 years ago

/lgtm /approve

jetstack-bot commented 4 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: meyskens, wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/jetstack/cert-manager-nginx-plus-lab/blob/master/OWNERS)~~ [meyskens] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment