search

jetstack / jetstack-secure

Open source components of Jetstack Secure
https://www.jetstack.io/jetstack-secure/
Apache License 2.0
252 stars 24 forks source link

[VC-32659] Remove the default CPU limit #539

Closed wallrj closed 1 week ago

wallrj commented 1 month ago

In https://docs.venafi.cloud/vaas/k8s-components/c-k8s-components-best-practice/#cpu we say:

Read Stop Using CPU Limits on Kubernetes, to learn why the best practice is to set CPU requests, but not limits.

So I've removed the default CPU limit from the chart values for venafi-kubernetes-agent.

I have not changed the jetstack-agent charts, because I think it is now considered legacy.

I also removed the note about using vertical pod autoscaler, because it seems irrelevant. We don't mention VPA in the documentation or in the other charts AFAIK.

maelvls commented 1 week ago

@tfadeyi Hey, I'm not sure whether this needs to be reviewed by you, WDYT?

tfadeyi commented 1 week ago

LGTM

I don't think it requires my approval, I think @wallrj should have permission to merge