search

jetstack / jetstack-secure

Open-source components of Jetstack Secure.
https://venafi.com/jetstack-consult/
Apache License 2.0
251 stars 24 forks source link

feat: enable volumes and volumeMounts to be passed to the jetstack-agent deployment #540

Closed hawksight closed 3 months ago

hawksight commented 3 months ago

I was working with a customer and needed to pass a configmap mount to the deployment. This is not currently available in the chart. This PR adds this capability in a generic way, similar to how it is done in the cert-manager chart.

I have specifically not created a new release of the chart. I intend to do a simple followup PR to release 0.3.2.

hawksight commented 3 months ago

@aidy thank you, have corrected those now. Can you cast one more eye over the changes please?

hawksight commented 3 months ago

should probably also bring these changes into the venafi agent chart

Agreed, but I don't have a CTA for that, and it doesn't help the customer problem I have. So I'll drop that as an issue for now. #541