search

jetstack / kube-lego

DEPRECATED: Automatically request certificates for Kubernetes Ingress resources from Let's Encrypt
Apache License 2.0
2.16k stars 267 forks source link

"creating new secret" log statement is misleading #161

Closed ahmetb closed 7 years ago

ahmetb commented 7 years ago

When I see log statement:

...
time="2017-04-21T19:02:03Z" level=info msg="creating new secret" context=secret name=example-tls namespace=default
time="2017-04-21T19:02:03Z" level=info msg="no cert associated with ingress" context="ingress_tls" name=example-ingress namespace=default
time="2017-04-21T19:02:03Z" level=info msg="requesting certificate for ngx.alp.im" context="ingress_tls" name=example-ingress namespace=default
...

it makes me think that the secret is created successfully because there's no error.

Then when I kubectl get secrets I don't see any tls secrets. Maybe modify to either:

For any future/present tense logs, if you log the outcome as well e.g created new secret succesfully/could not create secret this would not be a problem.