search

jetstack / kube-lego

DEPRECATED: Automatically request certificates for Kubernetes Ingress resources from Let's Encrypt
Apache License 2.0
2.16k stars 267 forks source link

DNS-01 challange: solver for AWS Route53 #181

Closed mkokho closed 6 years ago

mkokho commented 7 years ago

An attempt to add solvers for DNS-01 challenges. It is half-interfaces, half-implementations.

The failing test is the e2e test. Not sure whether it's possible to mock route53 client and still get successful response from Let's Encrypt. I'm happy to remove it.

bsudy commented 7 years ago

We are really interested in this PR. Could you please update the status? What are the outstanding issues? Have you tested it in real? We are doing client side certificate that would block the acme challenge endpoint.

mkokho commented 7 years ago

Sorry, I changed the company and don't work with Kubernetes anymore. There is an e2e test. It is not automatic, and it will fail in CI environment, because you need AWS credential and a domain in Route 53. But I used it on my laptop, and it worked wonderfully. The test is TestAcmeDNS01_E2E

jetstack-bot commented 6 years ago

@mkokho: PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/devel/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.