search

jetstack / kube-lego

DEPRECATED: Automatically request certificates for Kubernetes Ingress resources from Let's Encrypt
Apache License 2.0
2.16k stars 267 forks source link

Do not crash when cannot verifying LE user #187

Closed pichouk closed 7 years ago

pichouk commented 7 years ago

Try to fix #185 Return an error when cannot verifying LE user. I'm not go developer, maybe my patch is not working :smile:

pichouk commented 7 years ago

Up ? :)

pichouk commented 7 years ago

I'll try to test but honestly I'm not at all a Go developer. I have a lot of problems understanding and make working the Go dependencies system, so I cannot build the image. I'll give it another try later.

pichouk commented 7 years ago

I build the pichouk/lego-test Docker image to test. Seems OK but cannot reproduce since, with an invalid ACME server, kube-lego get an error before reaching this point. I'll see if I can setup a fake server which return HTTP 504 (like in #185 )

pichouk commented 7 years ago

Closing, the repository seems inactive and I think it will never be merged.