search

jetstack / kube-lego

DEPRECATED: Automatically request certificates for Kubernetes Ingress resources from Let's Encrypt
Apache License 2.0
2.16k stars 267 forks source link

fix(pkg/kubelego) do not match ingress class with provider name #195

Closed rochacon closed 7 years ago

rochacon commented 7 years ago

While trying to use kube-lego with an ingress class different than nginx and gce, I was not able to retrieve certificates from Let's Encrypt, even though the class was considered as supported. Kube-Lego was simply skipping the ingress resources due to the ingress class name not matching the kube-lego provider name.

To fix that I replaced the provider and class name matching with the ingress class settings checks (Ingress.Ignore() method), ignoring only the ingress resources that do not match the supported class names and applying the valid resources to every registered provider.

I'm also submitting #194 that enables customizing the desired providers, to avoid any weird cases that may appear by applying the same ingress resources on both providers.

Related to #189

jackhopner commented 7 years ago

Alternative solution - https://github.com/jetstack/kube-lego/pull/202

troian commented 7 years ago

Indispensable PR. Any chance get it merged soon?

munnerz commented 7 years ago

Closed in favour of #202 - however, thanks for this and thanks for your feedback on #202!