search

jetstack / kube-lego

DEPRECATED: Automatically request certificates for Kubernetes Ingress resources from Let's Encrypt
Apache License 2.0
2.16k stars 267 forks source link

break up infinite update loop #137 #204

Closed bvoss closed 7 years ago

bvoss commented 7 years ago

https://github.com/jetstack/kube-lego/issues/137

gianrubio commented 7 years ago

Nice job @bvoss, the nginx controller do the same treatment to compare ingress resources.

munnerz commented 7 years ago

Thanks very much for this @bvoss. In future we may look at some kind of hash based check of the ingress spec to determine whether to update, but in the meantime this works perfectly.

ahmetb commented 7 years ago

Is this released in a tagged version? I am using jetstack/kube-lego:0.1.4 but still seeing this behavior. Opened #216 and #198. (edit: looks like the latest release doesn't have the commit.)

gianrubio commented 7 years ago

Please try the canary image: jetstack/kube-lego:canary

On Wed, 28 Jun 2017 at 04:21, Ahmet Alp Balkan notifications@github.com wrote:

Is this released in a tagged version? I am using jetstack/kube-lego:0.1.4 but still seeing this behavior. Opened #216 https://github.com/jetstack/kube-lego/issues/216 and #198 https://github.com/jetstack/kube-lego/issues/198.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/jetstack/kube-lego/pull/204#issuecomment-311538383, or mute the thread https://github.com/notifications/unsubscribe-auth/AFbljILhpFaEb6-zCAjl7sbSzysh_I4Aks5sIbiogaJpZM4N1dO1 .

-- Giancarlo Rubio

naveensrinivasan commented 7 years ago

@munnerz With the canary release, we are getting any acme challenge which is not getting the certs. Any clue as to what we could do?